Skip to content

feat(checker): add Apache commons-compress checker (#1040) #1666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 25, 2022
Merged

feat(checker): add Apache commons-compress checker (#1040) #1666

merged 10 commits into from
May 25, 2022

Conversation

b31ngd3v
Copy link
Contributor

@b31ngd3v
Copy link
Contributor Author

b31ngd3v commented May 12, 2022

Manual Test Results

apache-commons-compress-1.10-2-omv4000.noarch.rpm

image

commons-compress-1.16.1.jar

image

@codecov-commenter
Copy link

Codecov Report

Merging #1666 (26a9160) into main (03b58d4) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1666      +/-   ##
==========================================
- Coverage   80.45%   80.38%   -0.08%     
==========================================
  Files         293      295       +2     
  Lines        6041     6050       +9     
  Branches      992      993       +1     
==========================================
+ Hits         4860     4863       +3     
- Misses        972      977       +5     
- Partials      209      210       +1     
Flag Coverage Δ
longtests 80.38% <100.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/checkers/__init__.py 95.45% <ø> (ø)
cve_bin_tool/checkers/commons_compress.py 100.00% <100.00%> (ø)
test/test_data/commons_compress.py 100.00% <100.00%> (ø)
cve_bin_tool/nvd_api.py 75.00% <0.00%> (-9.49%) ⬇️
cve_bin_tool/cli.py 72.84% <0.00%> (+0.43%) ⬆️
cve_bin_tool/cvedb.py 86.61% <0.00%> (+1.09%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@b31ngd3v
Copy link
Contributor Author

b31ngd3v commented May 18, 2022

image
in github ci two mapping tests for commons_compress were failing in windows environment, so i installed windows (in vm) and installed the same version of python that was used in the test, and then ran the mapping tests for commons_compress, but there was no error. so i can't figure out what the problem is!

image
image

@b31ngd3v
Copy link
Contributor Author

b31ngd3v commented May 18, 2022

i even ran the test on the same windows server version as github ci but unable to reproduce the mapping error!!

image

@terriko
Copy link
Contributor

terriko commented May 24, 2022

That is weird. If it were a local thing I'd assume it was a checker-not-loading issue, but we don't usually see those in Github Actions. I'm going to go ahead and update the branch and let it re-run the tests just in case it was something temporary.

@b31ngd3v
Copy link
Contributor Author

same thing ☹️ the windows test failed again!! should i remove the version mapping tests? what do you ( @terriko ) recommend?

@b31ngd3v b31ngd3v requested a review from terriko May 24, 2022 21:49
@b31ngd3v
Copy link
Contributor Author

@terriko btw this test (test/test_cli.py::TestCLI::test_console_output_depending_reportlab_existence) is failing everywhere

@b31ngd3v
Copy link
Contributor Author

thanks @terriko the mapping tests are passing now 😄

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for tests to run but this should be good to merge.

@terriko terriko merged commit 96f98b3 into intel:main May 25, 2022
@b31ngd3v b31ngd3v deleted the dev branch May 25, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New checker: Apache commons-compress
3 participants